Ignore EC PARAMETER blocks during issuer import #16721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While older versions of Vault supported sending this, we broke such support in 1.11. Ignore them from the manage issuers endpoint (which is aliased to the old /config/ca path) -- but keep erring in the import keys paths. The latter is a new endpoint not aliased to anything and only expects a single PEM block. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
requested review from
kitography,
schultz-is,
stevendpclark and
a team
stevendpclark
approved these changes
Aug 15, 2022
cipherboy
commented
Aug 15, 2022
There was a problem hiding this comment.
Note that on Vault 1.10, the parsing code was here: https://github.com/hashicorp/vault/blob/main/sdk/helper/certutil/helpers.go#L258
Since we didn't know the type (and it didn't decode successfully as either a key or a cert), we just dropped it from the bundle. Now we care more about the types of the entries in bundles and so we're wanting to explicitly ignore things we know are safe to ignore, and categorize the rest appropriately.
Signed-off-by: Alexander Scheel <[email protected]>
schultz-is
approved these changes
Aug 15, 2022
Signed-off-by: Alexander Scheel <[email protected]>
stevendpclark
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While older versions of Vault supported sending this, we broke such
support in 1.11. Ignore them from the manage issuers endpoint (which is
aliased to the old
/config/capath) -- but keep erring in the importkeys paths. The latter is a new endpoint not aliased to anything and
only expects a single PEM block.
Signed-off-by: Alexander Scheel <[email protected]>Resolves: #16667