Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version-aware plugin catalog #16688

Merged
merged 9 commits into from
Aug 25, 2022
Merged

Version-aware plugin catalog #16688

merged 9 commits into from
Aug 25, 2022

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Aug 11, 2022 •
edited
Loading

This PR adds the ability to register, query and delete versioned plugins, but no capability to use them yet.

Still to do (some of which may get done in a future PR):

  • Website documentation
  • Manual testing
  • Possibly follow that up with some more automated testing
  • CLI updates and CLI tests

@tomhjp tomhjp requested review from swenson, fairclothjm and a team August 11, 2022 19:37
swenson
swenson approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just a couple of small questions/nits

vault/logical_system.go Outdated Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
vault/plugin_catalog.go Outdated Show resolved Hide resolved
fairclothjm
fairclothjm approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swenson swenson mentioned this pull request Aug 24, 2022
Merged
@tomhjp tomhjp force-pushed the version-aware-plugin-catalog branch from bd11bb7 to 403192c Compare August 25, 2022 11:16
swenson
swenson approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

fairclothjm
fairclothjm approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mpalmi
mpalmi approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@mpalmi mpalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's in great shape. I pulled it down and rebased my deprecation status changes on it and (to no one's surprise) nothing breaks. Still kicking the tires a bit, but 👍.

@tomhjp tomhjp merged commit 7616505 into main Aug 25, 2022
@tomhjp tomhjp deleted the version-aware-plugin-catalog branch August 25, 2022 20:31
@tomhjp tomhjp mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

@mpalmi mpalmi mpalmi approved these changes

@swenson swenson swenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomhjp @swenson @mpalmi @fairclothjm