Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hana - Add username customization #16631

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Hana - Add username customization #16631

merged 4 commits into from
Aug 8, 2022

Conversation

Zlaticanin
Copy link
Contributor

@Zlaticanin Zlaticanin commented Aug 8, 2022

Adds the ability to customize username generation for dynamic users in HanaDB.

Uses the new field username_template with the go template language.

@Zlaticanin Zlaticanin requested a review from taoism4504 as a code owner August 8, 2022 19:04
@Zlaticanin Zlaticanin requested a review from a team August 8, 2022 19:04
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zlaticanin Zlaticanin requested review from a team and removed request for taoism4504 August 8, 2022 19:38
@Zlaticanin
Copy link
Contributor Author

can we also update this doc page as well?

https://www.vaultproject.io/docs/secrets/databases#database-capabilities

Just did. Thank you!

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvn calvn added this to the 1.12.0-rc1 milestone Aug 8, 2022
Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Zlaticanin Zlaticanin merged commit e4968ca into main Aug 8, 2022
@Zlaticanin Zlaticanin deleted the hanadbusernametemplate branch August 8, 2022 21:01
@Zlaticanin Zlaticanin restored the hanadbusernametemplate branch September 1, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants