Added unique identifier to each request

[ghost]

Fixes #1617

[ghost]

This file should not have been changed for this PR. Had an issue switching between branches.

[vishalnayak]

This should also be taken out.

[vishalnayak]

Other then the comment of taking out the token_store changes from this PR, LGTM!

[jefferai]

I think we should do this as early as possible -- in http/logical.go in the buildLogicalRequest function. That way we can refer to it at any point in time, even if that's still in the http code. Right now we're only exposing it for auditing, but that could change in the future.

[jefferai]

Sorry, this comment should actually be for vault/request_handling.go -- when I was scrolling back up I didn't notice I was at the wrong place :-)

[jefferai]

Although it applies here too. buildLogicalRequest is called in both handleSysStepDown and handleSysSeal, so by moving the UUID generation code there we don't need to duplicate it anywhere else.

[jefferai]

There are a couple more things that need to be done here:

1. In logical/sanitize.go function SanitizeResponse, the HTTPResponse struct needs to be updated to contain a RequestID (request_id).

2. Once (1) is done, the field in the response over the wire has to actually be populated. The SanitizeResponse function only takes in a logical.Response. Probably the right thing to do would be to create a RequestID field in logical.Response and populate it. This will probably break nearly every single test though. It is probably sufficient to instead ensure that we populate the value after calling SanitizeResponse. This is in request_handling.go function wrapInCubbyhole where fortunately the logical.Request is available, so it's easy. The other spot is http/logical.go where we don't have logical.Request now, but we only ever call it from one location -- so we can simply pass in the request into respondLogical and use it to populate the HTTPResponse after the call.

3. The current code won't actually write the ID into the audit logs. To do this, the structs in audit/format_json.go need to be updated, and then the code above that actually puts the values into the structs also has to be updated to copy the ID out of the request object and into the audit object.

[jefferai]

You can simply use httpResp here and then set the request ID that comes out, rather than creating a new variable and assigning afterwards.

[ghost]

I received an error in my attempt to set requestID directly because httpResp is an interface with no methods. If this isn't the way to handle it, I can change it.

[jefferai]

Oh, cool -- you're right. I didn't look up enough in the function. No worries!

[jefferai]

LGTM! 🚢