-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command/server: add dev-tls flag #16421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really should've batched these comments... :-/
But over all, I really like this and its something I've been wanting to do for a while (I added a tlsvault
userscript instead which also has agent capabilities).
Other than the comments above, the one below is the only one I'd really suggest changing unless other people have strong comments. Looks good from a crypto perspective though. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three nits you can ignore if you want, but a reasonable suggestion to avoid duplicate code with the SDK (that'd fix another nit). :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New cert changes look perfect. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nit comments, feel free to ignore. Otherwise, the feature looks great and should be super helpful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed the docs file (server.mdx
), but looks good to me. Super excited about this feature.
This adds new server subcommands,
-dev-tls
and-dev-tls-cert-dir
, which will generate self-signed CA, server certificate, private key and will configure Vault to use them for TLS. This is helpful if you want to do dev work against a TLS enabled server. The generated certs are valid for 1 year.During startup, the server will output the location of the CA so you can easily set the
VAULT_CACERT
environment variable:Additionally you can specify
-dev-tls-cert-dir
to configure the directory where the TLS files are created. This will be helpful for guides and automated environments.