-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PGP subkeys support #16224
Merged
Merged
fix: PGP subkeys support #16224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greut
force-pushed
the
fix/openpgp-subkeys
branch
from
July 5, 2022 06:50
6a577b6
to
9692fcb
Compare
Signed-off-by: Yoan Blanc <[email protected]>
Signed-off-by: Yoan Blanc <[email protected]>
@cipherboy hey opinions on this or can this be considered for merging? |
kitography
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about this during a team meeting, and this update makes sense.
We aren't going to have time to verify anything for 1.12.
cipherboy
approved these changes
Sep 22, 2022
As 1.12 has been branched, I feel good merging this now. Thank you @greut! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2372
My key https://keybase.io/yblanc/pgp_keys.asc is composed of subkeys, some of them are expired.
When doing the
openpgp.Encrypt
(https://github.com/hashicorp/vault/blob/main/helper/pgpkeys/encrypt_decrypt.go#L29=), it takes the first one resulting in a message I cannot decrypt.I've also tried using the upstream
golang.org/x/crypto/openpgp
and it suffers the same issue. However ProtonMail's fork does it correctly.The problem
Using main, I cannot decrypt the new unseal key, hence verify.
Using this branch, the new unseal key can be successfully decrypted.
NB: when downloading the key from keybase using
keybase:yblanc
it seems okay. We like to bake them into the AMI we use though.