Fix bug where id not existing in multiplexing map causes panic #16094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
approved these changes
Jun 21, 2022
calvn
reviewed
Jun 21, 2022
Co-authored-by: Calvin Leung Huang <[email protected]>
calvn
approved these changes
Jun 21, 2022
jasonodonnell
added a commit
that referenced
this pull request
Jun 22, 2022
* multiplexing: guard against connection panic * changelog * Update vault/plugin_catalog.go Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]>
jasonodonnell
added a commit
that referenced
this pull request
Jun 22, 2022
* multiplexing: guard against connection panic * changelog * Update vault/plugin_catalog.go Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]>
jasonodonnell
added a commit
that referenced
this pull request
Jun 22, 2022
… (#16117) * multiplexing: guard against connection panic * changelog * Update vault/plugin_catalog.go Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]>
jasonodonnell
added a commit
that referenced
this pull request
Jun 22, 2022
… (#16116) * multiplexing: guard against connection panic * changelog * Update vault/plugin_catalog.go Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guarding against a potential panic if the id does not exist in the connections map. I haven't tracked down why this would occur yet, but this will at least prevent a panic.