Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass context to postgres queries #15866

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

bhowe34
Copy link
Contributor

@bhowe34 bhowe34 commented Jun 8, 2022

I have observed postgres backend query times far exceed request time in cases where the client cancels the request (usually because postgres is not responding fast enough). This solves the issue by allowing the postgres query to be canceled when the associated request is cancelled.

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 8, 2022

CLA assistant check
All committers have signed the CLA.

@bhowe34 bhowe34 marked this pull request as ready for review June 8, 2022 13:06
@cipherboy cipherboy requested a review from a team June 8, 2022 13:22
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense with me, but asking for review from my Ecosystem colleagues... :)

Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on behalf of ecosystem

changelog/15866.txt Outdated Show resolved Hide resolved
Co-authored-by: Alexander Scheel <[email protected]>
@cipherboy cipherboy merged commit df279b9 into hashicorp:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants