Backport of Revert UI: replace localStorage with sessionStorage into release/1.10.x #15773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/revert-session-storage/informally-kind-sole
branch
from
4a89230 to
33860ab
Compare
arnav28
approved these changes
Jun 2, 2022
…/informally-kind-sole
…/informally-kind-sole
…/informally-kind-sole
…/informally-kind-sole
…/informally-kind-sole
…/informally-kind-sole
…/informally-kind-sole
…/informally-kind-sole
…/informally-kind-sole
…/informally-kind-sole
Monkeychip
approved these changes
Jun 27, 2022
…/informally-kind-sole
Remove test changes
|
Closing for this manual PR. #16169 |
auto-merge was automatically disabled
June 28, 2022 17:24
Pull request was closed
Monkeychip
deleted the
backport/ui/revert-session-storage/informally-kind-sole
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15769 to be assessed for backporting due to the inclusion of the label backport/1.10.x.
The below text is copied from the body of the original PR.
In #14054 we moved from localStorage to using sessionStorage in an effort to make the Vault UI auth sessions tab-specific rather than browser-wide. However, after hearing from the community we are going to revisit our approach to browser security and revert this change for now.
Overview of commits