VAULT-6371 Fix issue with lease quotas on read requests that generate leases #15735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crux of the issue here was that lease quota checks get routed differently to rate limit checks. In the case of lease quota checks, the MountPoint was not always present on the logical.Request. In essence, when searching for an applicable quota to apply to the request, it would not correctly find the applicable quota as it uses the MountPoint as part of searching for applicable quotas. It seems to apply only to endpoints that generate a lease on Read.
Lease quotas now apply properly on quotas based on mounts that when generating a lease on a Read:
Tests added as part of enterprise PR.