Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/Fix form validation issues #15560

Merged
merged 18 commits into from
May 25, 2022
Merged

UI/Fix form validation issues #15560

merged 18 commits into from
May 25, 2022

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented May 20, 2022 •
edited
Loading

Fixes form validations ignoring the defaultValue and disabling the form even though 0 is valid.
Screen Shot 2022-05-20 at 5 07 44 PM

After fix:
validations

@hellobontempo hellobontempo added ui bug Used to indicate a potential bug labels May 20, 2022
@hellobontempo hellobontempo changed the title UI/Fix validation issues, regression from Ember upgrade UI/Fix form validation issues May 21, 2022
hashishaw
hashishaw suggested changes May 23, 2022
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing! Good job tracking this down

ui/lib/core/addon/components/form-field.hbs Outdated Show resolved Hide resolved
ui/tests/unit/utils/validators-test.js Show resolved Hide resolved
@hellobontempo hellobontempo requested a review from hashishaw May 23, 2022 23:04
hashishaw
hashishaw approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just one small change and it's good to go (assuming design approval)

ui/app/components/mount-backend-form.js Outdated Show resolved Hide resolved
ui/app/templates/components/mount-backend-form.hbs Outdated Show resolved Hide resolved
zofskeez
zofskeez reviewed May 25, 2022
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! It might be nice to add a model-validations test for the new invalidFormMessage property.

ui/app/decorators/model-validations.js Outdated Show resolved Hide resolved
ui/app/decorators/model-validations.js Show resolved Hide resolved
ui/app/decorators/model-validations.js Outdated Show resolved Hide resolved
ui/app/models/secret-v2.js Show resolved Hide resolved
ui/lib/core/addon/components/alert-inline.js Outdated Show resolved Hide resolved
ui/lib/core/addon/templates/components/alert-inline.hbs Outdated Show resolved Hide resolved
@hellobontempo hellobontempo added this to the 1.11.0-rc1 milestone May 25, 2022
@hellobontempo hellobontempo merged commit 9fd8a97 into main May 25, 2022
@hellobontempo hellobontempo deleted the ui/fix-validation-form-errors branch May 25, 2022 18:22
Gabrielopesantos pushed a commit to Gabrielopesantos/vault that referenced this pull request Jun 6, 2022
@hellobontempo @Gabrielopesantos
UI/Fix form validation issues (hashicorp#15560)
3ee7c1d 
* clean up validators

* fix getter overriding user input

* add changelog

* remove asString option

* move invalid check up

* remove asString everywhere

* revert input value defaults

* undo form disabling if validation errors

* address comments

* remove or

* add validation message to form, create pseudo loading icon

* whole alert disappears with refresh

* glimmerize alert-inline

* add tests

* rename variables for consistency

* spread attributes to glimmerized component

* address comments

* add validation test
@hellobontempo hellobontempo mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zofskeez zofskeez zofskeez left review comments

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Milestone
1.11.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@hellobontempo @zofskeez @hashishaw