Add role patching test case #15545
Merged
Add role patching test case #15545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
stevendpclark
approved these changes
May 20, 2022
|
Yeah, I could probably do that here. |
Signed-off-by: Alexander Scheel <[email protected]>
stevendpclark
approved these changes
May 20, 2022
|
Thanks! |
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
* Add tests for role patching Signed-off-by: Alexander Scheel <[email protected]> * Prevent bad issuer names on update Signed-off-by: Alexander Scheel <[email protected]> * Add documentation on PATCH operations Signed-off-by: Alexander Scheel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates almost all fields individually in a role, with the exceptions of (key_type, key_bits, and signature_bits) due to inter-dependencies between them.
Also, fixes a bug spotted by @stevendpclark during review of #15510, where both Update and Patch issuer didn't validate the new name.