-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api/monitor: Adding log format to monitor command and debug #15536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidadeleon
force-pushed
the
davidadeleon-add-format-flag-to-monitor
branch
from
May 20, 2022 18:58
c3d4b5c
to
bf23ca8
Compare
jasonodonnell
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ncabatoff
reviewed
May 20, 2022
davidadeleon
force-pushed
the
davidadeleon-add-format-flag-to-monitor
branch
from
May 20, 2022 20:36
f7d94d6
to
5b1c8b7
Compare
ncabatoff
reviewed
May 20, 2022
ccapurso
approved these changes
May 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment on one of the doc changes but otherwise looks good!
Co-authored-by: Chris Capurso <[email protected]>
davidadeleon
added a commit
that referenced
this pull request
Jun 3, 2022
* Correct handling of "unspecified" log level * Setting log-format default on monitor path * Create changelog file * Update website/content/api-docs/system/monitor.mdx Co-authored-by: Chris Capurso <[email protected]> Co-authored-by: Chris Capurso <[email protected]>
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
…p#15536) * Correct handling of "unspecified" log level * Setting log-format default on monitor path * Create changelog file * Update website/content/api-docs/system/monitor.mdx Co-authored-by: Chris Capurso <[email protected]> Co-authored-by: Chris Capurso <[email protected]>
davidadeleon
added a commit
that referenced
this pull request
Jun 6, 2022
…15791) * Correct handling of "unspecified" log level * Setting log-format default on monitor path * Create changelog file * Update website/content/api-docs/system/monitor.mdx Co-authored-by: Chris Capurso <[email protected]> Co-authored-by: Chris Capurso <[email protected]> Co-authored-by: Chris Capurso <[email protected]> Co-authored-by: Jason O'Donnell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding log_format flag to monitor endpoint as well as debug command. This will allow the option for vault logs being emitted via monitor to come through as JSON format. The default behavior is to emit in the standard log format.
Usage:
vault monitor -log-level=DEBUG -log-format=JSON
curl -H "X-Vault-Request: true" -H "X-Vault-Token: $(vault print token)" http://127.0.0.1:8200/v1/sys/monitor?log_format=json&log_level=trace
vault debug -target=log -log-format=json