Fix UBI setting environment variable #15438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
added
core
tvoran
approved these changes
May 16, 2022
This variable doesn't use ParseBool and thus strictly requires "true" as the value. Signed-off-by: Alexander Scheel <[email protected]>
|
@akshya96 I dropped the second change; will merge this without the changes to the config var as I see you've done that in another PR. |
cipherboy
force-pushed
the
cipherboy-fix-env-var
branch
from
68bfde6 to
b4ad204
Compare
cipherboy
added a commit
that referenced
this pull request
May 31, 2022
This variable doesn't use ParseBool and thus strictly requires "true" as the value. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added a commit
that referenced
this pull request
May 31, 2022
This variable doesn't use ParseBool and thus strictly requires "true" as the value. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
added a commit
that referenced
this pull request
May 31, 2022
* UBI Containerfile - CRT Enablement (#15272) * Copy UBI Dockerfile into Vault This Dockerfile was modeled off of the existing Alpine Dockerfile (in this repo) and the external Dockerfile from the docker-vault repo: > https://github.com/hashicorp/docker-vault/blob/master/ubi/Dockerfile We also import the UBI-specific docker-entrypoint.sh, as certain RHEL/Alpine changes (like interpreter) require a separate entry script. Signed-off-by: Alexander Scheel <[email protected]> * Add UBI build to CRT pipeline Also adds workflow_dispatch to the CRT pipeline, to allow manually triggering CRT from PRs, when desired. Signed-off-by: Alexander Scheel <[email protected]> * Update Dockerfile Co-authored-by: Sam Salisbury <[email protected]> * Update Dockerfile Co-authored-by: Sam Salisbury <[email protected]> * Update Dockerfile Co-authored-by: Sam Salisbury <[email protected]> * Update Dockerfile * Update Dockerfile * Update build.yml Allow for both push to arbitrary branch plus workflow dispatch, per Newsletter article. ------ Also pulls in changes from 0ee2ac3 as this wasn't backported. ------ Co-authored-by: Sam Salisbury <[email protected]> * Set HOME=/home/vault in UBI Dockerfile (#15439) Signed-off-by: Alexander Scheel <[email protected]> * Fix ubi-docker-entrypoint.sh->docker-entrypoint.sh (#15443) It is believed to break the helm chart; see also: #15272 (comment) Signed-off-by: Alexander Scheel <[email protected]> * Fix value of VAULT_DISABLE_FILE_PERMISSIONS_CHECK (#15438) This variable doesn't use ParseBool and thus strictly requires "true" as the value. Signed-off-by: Alexander Scheel <[email protected]> * Update Dockerfile Co-authored-by: Theron Voran <[email protected]> Co-authored-by: Sam Salisbury <[email protected]> Co-authored-by: Theron Voran <[email protected]>
cipherboy
added a commit
that referenced
this pull request
May 31, 2022
* UBI Containerfile - CRT Enablement (#15272) * Copy UBI Dockerfile into Vault This Dockerfile was modeled off of the existing Alpine Dockerfile (in this repo) and the external Dockerfile from the docker-vault repo: > https://github.com/hashicorp/docker-vault/blob/master/ubi/Dockerfile We also import the UBI-specific docker-entrypoint.sh, as certain RHEL/Alpine changes (like interpreter) require a separate entry script. Signed-off-by: Alexander Scheel <[email protected]> * Add UBI build to CRT pipeline Also adds workflow_dispatch to the CRT pipeline, to allow manually triggering CRT from PRs, when desired. Signed-off-by: Alexander Scheel <[email protected]> * Update Dockerfile Co-authored-by: Sam Salisbury <[email protected]> * Update Dockerfile Co-authored-by: Sam Salisbury <[email protected]> * Update Dockerfile Co-authored-by: Sam Salisbury <[email protected]> * Update Dockerfile * Update Dockerfile * Update build.yml Allow for both push to arbitrary branch plus workflow dispatch, per Newsletter article. ------ Also pulls in changes from 0ee2ac3 as this wasn't backported. ------ Co-authored-by: Sam Salisbury <[email protected]> * Set HOME=/home/vault in UBI Dockerfile (#15439) Signed-off-by: Alexander Scheel <[email protected]> * Fix ubi-docker-entrypoint.sh->docker-entrypoint.sh (#15443) It is believed to break the helm chart; see also: #15272 (comment) Signed-off-by: Alexander Scheel <[email protected]> * Fix value of VAULT_DISABLE_FILE_PERMISSIONS_CHECK (#15438) This variable doesn't use ParseBool and thus strictly requires "true" as the value. Signed-off-by: Alexander Scheel <[email protected]> * Update Dockerfile Co-authored-by: Theron Voran <[email protected]> Co-authored-by: Sam Salisbury <[email protected]> Co-authored-by: Theron Voran <[email protected]>
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
This variable doesn't use ParseBool and thus strictly requires "true" as the value. Signed-off-by: Alexander Scheel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VAULT_DISABLE_FILE_PERMISSIONS_CHECKpresently only takes the valuetrueand doesn't useParseBool; change the behavior to match most other environment variables (since it is new), but also update the UBI image to use the literaltrue.@akshya96 If this will be reverted, I'm happy to remove the updates to the config. But since its still here, I figured I'd aim for consistency. I think, if you wanted to avoid a complete revert and allow users to manually enable the feature, you could update this new code to just set
skipCheckPermissions := trueby default and then just update the docs.My 2c.