UI/ fix firefox not recognizing csv export #15364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav28
reviewed
May 11, 2022
| @@ -8,7 +8,8 @@ import Service from '@ember/service'; | |||
|
|
|||
| export default class DownloadCsvService extends Service { | |||
| download(filename, content) { | |||
| let formattedFilename = filename?.replace(/\s+/g, '-') || 'vault-data.csv'; | |||
| // even though Blob type 'text/csv' is specified below, some browsers (ex. Firefox) require the filename has an explicit extension | |||
| let formattedFilename = `${filename?.replace(/\s+/g, '-')}.csv` || 'vault-data.csv'; | |||
There was a problem hiding this comment.
nit: filename param passed is without any extension right?
There was a problem hiding this comment.
Good question! That's correct, it's generated in the attribution component. I thought it'd simplify things to have the service take care of all csv/download related things.
get getCsvFileName() {
let endRange = this.isDateRange ? `-${this.args.endTimeDisplay}` : '';
let csvDateRange = this.args.startTimeDisplay + endRange;
return this.isSingleNamespace
? `clients_by_auth_method_${csvDateRange}`
: `clients_by_namespace_${csvDateRange}`;
}
arnav28
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the explicit
.csvextension in the filename, Firefox doesn't recognize the download file type.