Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAULT-14990] Support retrieving kv secret paths with trailing spaces #15188

Merged
merged 7 commits into from
May 10, 2022
Merged

[VAULT-14990] Support retrieving kv secret paths with trailing spaces #15188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d6b9f7
Support retrieiving kv trailing spaces
AnPucel Apr 22, 2022
37a475b
Fixing edge cases
AnPucel Apr 28, 2022
850314a
Fixing for go fmt
AnPucel May 9, 2022
1256275
Changelog
AnPucel May 9, 2022
bed6bfa
Code cleanup/comments
AnPucel May 9, 2022
0ac78e3
Simplify helpers
AnPucel May 10, 2022
f82ce09
Remove sanitization
AnPucel May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/15188.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
cli: kv get command now honors trailing spaces to retrieve secrets
```
6 changes: 4 additions & 2 deletions command/kv_get.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ func (c *KVGetCommand) Run(args []string) int {
// Parse the paths and grab the KV version
if mountFlagSyntax {
// In this case, this arg is the secret path (e.g. "foo").
partialPath = sanitizePath(args[0])
partialPath = args[0]

mountPath = sanitizePath(c.flagMount)
_, v2, err = isKVv2(mountPath, client)
if err != nil {
Expand All @@ -134,7 +135,8 @@ func (c *KVGetCommand) Run(args []string) int {
} else {
// In this case, this arg is a path-like combination of mountPath/secretPath.
// (e.g. "secret/foo")
partialPath = sanitizePath(args[0])
partialPath = args[0]

mountPath, v2, err = isKVv2(partialPath, client)
if err != nil {
c.UI.Error(err.Error())
Expand Down