Handle client count timezone #15167
Merged
Handle client count timezone #15167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Backend convert the timezone to UTC, to mitigate it's impact sending start and end date other than 1. Chose 10 and 20 randomly.
| } | ||
| if (end_time) { | ||
| if (Array.isArray(end_time)) { | ||
| let endYear = Number(end_time[0]); | ||
| let endMonth = Number(end_time[1]); | ||
| end_time = formatRFC3339(new Date(endYear, endMonth)); | ||
| end_time = formatRFC3339(new Date(endYear, endMonth, 20)); |
There was a problem hiding this comment.
When testing did the API always return with the last day of the month? Might be worth having backend take a look (or maybe you already have) to see if sending an arbitrary middle of the month day has any implications we're unaware of.
hellobontempo
approved these changes
May 20, 2022
Yes, confirmed with backend that they have startOfMonth, endOfMonth for start and end params. I tested it as well. 👍 |
arnav28
added a commit
that referenced
this pull request
Jun 1, 2022
Client count went through major refactoring in 1.10 and as a result straightforward backport was not possible.
arnav28
added a commit
that referenced
this pull request
Jun 1, 2022
* This is the backport for #15167 Client count went through major refactoring in 1.10 and as a result straightforward backport was not possible. * Added changelog * Fix test
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
* Handle client count timezone - Backend convert the timezone to UTC, to mitigate it's impact sending start and end date other than 1. Chose 10 and 20 randomly. * Added changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start and end date other than 1. Chose 10 and 20 randomly.