Backport of UI: Masked inputs always look the same when value is hidden into release/1.8.x #15029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
no changes, rolling manual |
hashishaw
deleted the
backport/ui/fix-obfuscated-string-reveal-details/really-comic-duck
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15025 to be assessed for backporting due to the inclusion of the label backport/1.8.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Previous to this fix, if a masked value had special characters such as é, à, è the masked value would give away where chose characters are in the string.
After this fix, masked display will be completely agnostic to the actual value -- always showing the same length and size of character. This PR addresses issue 13270
Before - you can tell without showing the value where the special character is
After - can no longer tell when masked the length or location of special characters
It's worth noting that the input will still show the true length and location of the special character. This is so that the user can type in the field without unmasking the value.
