Backport of Fix handling of default zero SignatureBits value with Any key type in PKI Secrets Engine into release/1.10.x #14892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14875 to be assessed for backporting due to the inclusion of the label backport/1.10.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
When using
KeyType="any"
on a role (whether explicitly or implicitlyvia a
sign-verbatim
like operation), we need to update the value ofSignatureBits
from its new value 0 to a per-key-type default value. Thiswill allow sign operations on these paths to function correctly, having
the correctly inferred default signature bit length.
Additionally, this allows the computed default value for key type to be
used for minimum size validation in the RSA/ECDSA paths. We additionally
enforce the 2048-minimum in this case as well.
`Signed-off-by: Alexander Scheel [email protected]
Fix defaults and validation of "any" KeyType
When
certutil
is given the placeholder any keytype, it attempts tovalidate and update the default zero value. However, in lacking a
default value for SignatureBits, it cannot update the value from the
zero value, thus causing validation to fail.
Add more awareness to the placeholder "any" value to
certutil
.`Signed-off-by: Alexander Scheel [email protected]
Resolves: #14863
This also includes two tests, including one written by @stevendpclark for checking this issue and ensuring we don't regress, one for roles and one for
sign-verbatim
.