Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/Wrong sentinel error message for auth methods #14551

Merged
merged 13 commits into from
Mar 18, 2022
Merged

UI/Wrong sentinel error message for auth methods #14551

merged 13 commits into from
Mar 18, 2022

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Mar 17, 2022 •
edited
Loading

This PR cleans up some error handling that was slightly inaccurate and glimmerizes the MessageError component.

Previously the UI was intercepting the API error message and displaying an incorrect error message and warning flag. Below I was logged in as a user who did not have permission to enable the userpass auth method. The following warning displayed:

Screen Shot 2022-03-16 at 4 24 45 PM

With fix:
Screen Shot 2022-03-17 at 12 47 26 PM

@vercel vercel bot temporarily deployed to Preview – vault March 17, 2022 01:51 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 17, 2022 01:59 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 17, 2022 22:13 Inactive
@hellobontempo hellobontempo added this to the 1.10.1 milestone Mar 17, 2022
@vercel vercel bot temporarily deployed to Preview – vault March 18, 2022 00:38 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 18, 2022 00:47 Inactive
hashishaw
hashishaw reviewed Mar 18, 2022
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far!

ui/app/components/mount-backend-form.js Outdated Show resolved Hide resolved
ui/app/components/mount-backend-form.js Show resolved Hide resolved
ui/lib/core/addon/components/message-error.js Outdated Show resolved Hide resolved
ui/app/templates/components/mount-backend-form.hbs Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault March 18, 2022 17:50 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 18, 2022 17:58 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 18, 2022 22:09 Inactive
Monkeychip
Monkeychip approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@vercel vercel bot temporarily deployed to Preview – vault March 18, 2022 22:52 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 18, 2022 22:52 Inactive
@hellobontempo hellobontempo modified the milestones: 1.10.1, 1.9.5 Mar 18, 2022
@hellobontempo hellobontempo added backport bug Used to indicate a potential bug backport/1.10.x labels Mar 18, 2022
@vercel vercel bot temporarily deployed to Preview – vault March 18, 2022 23:28 Inactive
@hellobontempo hellobontempo merged commit 4df3a7c into main Mar 18, 2022
This was referenced Mar 18, 2022
Closed
Closed
This was referenced Mar 21, 2022
Merged
Merged
hellobontempo added a commit that referenced this pull request Mar 22, 2022
@hellobontempo
Backport: UI/Wrong sentinel error message for auth methods #14551 (#1…
b6a8a3d 
…4632)

* cherry pick changes

* remove waitFor
@Monkeychip Monkeychip mentioned this pull request Mar 31, 2022
Merged
This was referenced Mar 31, 2022
Closed
Merged
@thiskevinwang thiskevinwang mentioned this pull request Apr 25, 2022
Closed
@hellobontempo hellobontempo deleted the ui/wrong-auth-sentinel-error branch June 7, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw left review comments

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Milestone
1.9.5
Development

Successfully merging this pull request may close these issues.
3 participants
@hellobontempo @Monkeychip @hashishaw