Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/multiplexing: overhaul plugin documentation #14509

Merged
merged 30 commits into from
Mar 22, 2022

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Mar 15, 2022

Rework some of the plugin documentation and add details on database plugin multiplexing feature.

The Plugins page has been moved as a top-level directory. It has been broken into Overview, Plugin Architecture and Plugin Development. The Plugin Portal has been moved to live under the top-level Plugin directory. The Plugin Backends page has been renamed to Plugin Management and moved under the top-level Plugin directory.

Screen Shot 2022-03-22 at 9 56 32 AM

🔍 Deploy Preview

@vercel vercel bot temporarily deployed to Preview – vault-storybook March 15, 2022 19:54 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 15, 2022 19:56 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 17, 2022 19:04 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 17, 2022 19:46 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 17, 2022 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 17, 2022 20:12 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 17, 2022 21:41 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 18, 2022 14:27 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 18, 2022 15:09 Inactive
@fairclothjm fairclothjm force-pushed the docs/vault-3570/plugin-multiplexing branch from 126e0b0 to a136fed Compare March 18, 2022 15:10
There is only one step required to upgrade from a non-multiplexed to a
multiplexed database plugin:

1. Change the `Serve` function call to `ServeMultiplex`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's just one step, no need to include a numbered step here.

Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise, LGTM. P.S-Understood about 'lazily'; I thought it was an unwanted adverb so thanks for the explanation :)

Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@fairclothjm fairclothjm merged commit 9680de8 into main Mar 22, 2022
@fairclothjm fairclothjm deleted the docs/vault-3570/plugin-multiplexing branch March 22, 2022 20:07
fairclothjm added a commit that referenced this pull request Mar 22, 2022
* docs/multiplexing: overhaul plugin documentation

* update nav data

* remove dupe nav data

* add external plugin section to index

* move custom plugin backends under internals/plugins

* remove ref to moved page

* revert moving custom plugin backends

* add building plugins from source section to plug dev

* add mux section to plugin arch

* add mux section to custom plugin page

* reorder custom database page

* use 'external plugin' where appropriate

* add link to plugin multiplexing

* fix example serve multiplex func call

* address review comments

* address review comments

* Minor format updates (#14590)

* mv Plugins to top-level; update upgrading plugins

* update links after changing paths

* add section on external plugin scaling characteristics

* add updates on plugin registration in plugin management page

* add plugin learn resource

* be more explicit about mux upgrade steps; add notes on when to avoid db muxing

* add plugin upgrade built-in section

* add caveats to built-in plugin upgrade

* improvements to built-in plugin override

* formatting, add redirects, correct multiplexing use case

* fix go-plugin link

* Apply suggestions from code review

Co-authored-by: Loann Le <[email protected]>

* remove single item list; add link to Database interface

Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Loann Le <[email protected]>
@fairclothjm fairclothjm added this to the 1.10 milestone Mar 22, 2022
fairclothjm added a commit that referenced this pull request Mar 22, 2022
* docs/multiplexing: overhaul plugin documentation

* update nav data

* remove dupe nav data

* add external plugin section to index

* move custom plugin backends under internals/plugins

* remove ref to moved page

* revert moving custom plugin backends

* add building plugins from source section to plug dev

* add mux section to plugin arch

* add mux section to custom plugin page

* reorder custom database page

* use 'external plugin' where appropriate

* add link to plugin multiplexing

* fix example serve multiplex func call

* address review comments

* address review comments

* Minor format updates (#14590)

* mv Plugins to top-level; update upgrading plugins

* update links after changing paths

* add section on external plugin scaling characteristics

* add updates on plugin registration in plugin management page

* add plugin learn resource

* be more explicit about mux upgrade steps; add notes on when to avoid db muxing

* add plugin upgrade built-in section

* add caveats to built-in plugin upgrade

* improvements to built-in plugin override

* formatting, add redirects, correct multiplexing use case

* fix go-plugin link

* Apply suggestions from code review

Co-authored-by: Loann Le <[email protected]>

* remove single item list; add link to Database interface

Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Loann Le <[email protected]>

Co-authored-by: Yoko Hyakuna <[email protected]>
Co-authored-by: Loann Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants