-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/multiplexing: overhaul plugin documentation #14509
Conversation
126e0b0
to
a136fed
Compare
There is only one step required to upgrade from a non-multiplexed to a | ||
multiplexed database plugin: | ||
|
||
1. Change the `Serve` function call to `ServeMultiplex`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's just one step, no need to include a numbered step here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, otherwise, LGTM. P.S-Understood about 'lazily'; I thought it was an unwanted adverb so thanks for the explanation :)
Co-authored-by: Loann Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it
* docs/multiplexing: overhaul plugin documentation * update nav data * remove dupe nav data * add external plugin section to index * move custom plugin backends under internals/plugins * remove ref to moved page * revert moving custom plugin backends * add building plugins from source section to plug dev * add mux section to plugin arch * add mux section to custom plugin page * reorder custom database page * use 'external plugin' where appropriate * add link to plugin multiplexing * fix example serve multiplex func call * address review comments * address review comments * Minor format updates (#14590) * mv Plugins to top-level; update upgrading plugins * update links after changing paths * add section on external plugin scaling characteristics * add updates on plugin registration in plugin management page * add plugin learn resource * be more explicit about mux upgrade steps; add notes on when to avoid db muxing * add plugin upgrade built-in section * add caveats to built-in plugin upgrade * improvements to built-in plugin override * formatting, add redirects, correct multiplexing use case * fix go-plugin link * Apply suggestions from code review Co-authored-by: Loann Le <[email protected]> * remove single item list; add link to Database interface Co-authored-by: Yoko Hyakuna <[email protected]> Co-authored-by: Loann Le <[email protected]>
* docs/multiplexing: overhaul plugin documentation * update nav data * remove dupe nav data * add external plugin section to index * move custom plugin backends under internals/plugins * remove ref to moved page * revert moving custom plugin backends * add building plugins from source section to plug dev * add mux section to plugin arch * add mux section to custom plugin page * reorder custom database page * use 'external plugin' where appropriate * add link to plugin multiplexing * fix example serve multiplex func call * address review comments * address review comments * Minor format updates (#14590) * mv Plugins to top-level; update upgrading plugins * update links after changing paths * add section on external plugin scaling characteristics * add updates on plugin registration in plugin management page * add plugin learn resource * be more explicit about mux upgrade steps; add notes on when to avoid db muxing * add plugin upgrade built-in section * add caveats to built-in plugin upgrade * improvements to built-in plugin override * formatting, add redirects, correct multiplexing use case * fix go-plugin link * Apply suggestions from code review Co-authored-by: Loann Le <[email protected]> * remove single item list; add link to Database interface Co-authored-by: Yoko Hyakuna <[email protected]> Co-authored-by: Loann Le <[email protected]> Co-authored-by: Yoko Hyakuna <[email protected]> Co-authored-by: Loann Le <[email protected]>
Rework some of the plugin documentation and add details on database plugin multiplexing feature.
The Plugins page has been moved as a top-level directory. It has been broken into Overview, Plugin Architecture and Plugin Development. The Plugin Portal has been moved to live under the top-level Plugin directory. The Plugin Backends page has been renamed to Plugin Management and moved under the top-level Plugin directory.
🔍 Deploy Preview