Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from mount move testing #14492

Merged
merged 7 commits into from
Mar 15, 2022
Merged

Fixes from mount move testing #14492

merged 7 commits into from
Mar 15, 2022

Conversation

pmmukh
Copy link
Contributor

@pmmukh pmmukh commented Mar 14, 2022

  • Adds a check for spaces in the source or destination mounts
  • Updates the auth move docs
  • Besides those 2 fixes from the manual testing, the PR also adds the changelog for the feature

Also, thanks to @akshya96 for all the testing catches!

@pmmukh pmmukh requested a review from taoism4504 as a code owner March 14, 2022 20:53
@vercel vercel bot temporarily deployed to Preview – vault March 14, 2022 21:00 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 14, 2022 21:00 Inactive
@pmmukh pmmukh requested review from ncabatoff, akshya96 and a team March 14, 2022 21:00
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 14, 2022 21:13 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 14, 2022 21:13 Inactive
Copy link
Contributor

@raskchanky raskchanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, looks good!

vault/logical_system.go Outdated Show resolved Hide resolved
vault/logical_system.go Outdated Show resolved Hide resolved
vault/logical_system_test.go Outdated Show resolved Hide resolved
vault/logical_system_test.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 14, 2022 21:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 14, 2022 21:23 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 14, 2022 21:23 Inactive
@pmmukh pmmukh merged commit 0cb4e16 into main Mar 15, 2022
@pmmukh pmmukh deleted the mount-move-cleanups branch March 15, 2022 18:11
pmmukh added a commit that referenced this pull request Mar 16, 2022
* Add validation, fix docs

* add changelog

* fmt fix

* Update vault/logical_system.go

Co-authored-by: Josh Black <[email protected]>

* Update vault/logical_system.go

Co-authored-by: Josh Black <[email protected]>

* Update vault/logical_system_test.go

Co-authored-by: Josh Black <[email protected]>

* Update vault/logical_system_test.go

Co-authored-by: Josh Black <[email protected]>

Co-authored-by: Josh Black <[email protected]>
pmmukh added a commit that referenced this pull request Mar 16, 2022
* Add validation, fix docs

* add changelog

* fmt fix

* Update vault/logical_system.go

Co-authored-by: Josh Black <[email protected]>

* Update vault/logical_system.go

Co-authored-by: Josh Black <[email protected]>

* Update vault/logical_system_test.go

Co-authored-by: Josh Black <[email protected]>

* Update vault/logical_system_test.go

Co-authored-by: Josh Black <[email protected]>

Co-authored-by: Josh Black <[email protected]>

Co-authored-by: Josh Black <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants