Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set header content type instead of overwriting all headers #14222

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Set header content type instead of overwriting all headers #14222

merged 2 commits into from
Feb 23, 2022

Conversation

dynajoe
Copy link
Contributor

@dynajoe dynajoe commented Feb 23, 2022

Fixes #14221

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview – vault-storybook February 23, 2022 12:40 Inactive
@ccapurso ccapurso added bug Used to indicate a potential bug core/api labels Feb 23, 2022
@ccapurso
Copy link
Contributor

Thank you for the contribution, @dynajoe! Would you be able to add a changelog entry by adding the following to changelog/14222.txt include the following text?

```release-note: bug
core/api: Fix overwriting of request headers when using JSONMergePatch.
```

@vercel vercel bot temporarily deployed to Preview – vault-storybook February 23, 2022 16:51 Inactive
@dynajoe
Copy link
Contributor Author

dynajoe commented Feb 23, 2022

Completed.

@ccapurso
Copy link
Contributor

Hi, @dynajoe. It looks like there is an extra 2 in your changelog filename. Would you be able to rename the file to match the PR number? Once the the changelog check passes this will be good to go and I will merge.

@dynajoe dynajoe force-pushed the jsonmergepatch-set-header branch from 746e139 to 06479b6 Compare February 23, 2022 21:38
@dynajoe
Copy link
Contributor Author

dynajoe commented Feb 23, 2022

Wow, good eye. Fixed.

ccapurso
ccapurso approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for catching this!

@ccapurso ccapurso merged commit e17724e into hashicorp:main Feb 23, 2022
@dynajoe dynajoe deleted the jsonmergepatch-set-header branch February 26, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccapurso ccapurso ccapurso approved these changes

Assignees
No one assigned
Labels
bug Used to indicate a potential bug core/api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSONMergePatch overwrites all headers removing X-Vault-Namespace among others
3 participants
@dynajoe @hashicorp-cla @ccapurso