Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify service_registration stanza version #14213

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Conversation

robmonte
Copy link
Member

A refactoring of #8776

This PR simply clarifies in the docs when the service_registration configuration option was added to Vault, and that it is not required when using Consul as the storage backend for Vault.

Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ccapurso ccapurso merged commit dd65169 into main Feb 23, 2022
@ccapurso ccapurso deleted the update-consul-serv-reg-docs branch February 23, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants