Ensure that fewer goroutines survive after a test completes #14197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ncabatoff
commented
Feb 22, 2022
ncabatoff
commented
- add Core.ShutdownWait that doesn't return until shutdown is done
- create the usedCodes cache on seal and nil it out on pre-seal so that the finalizer kills the janitor goroutine
- stop seal health check when sealing rather than wait for it to discover the active context is done
- make sure all lease-loading goroutines are done before returning from restore
- make uniquePoliciesGc discover closed quitCh immediately instead of only when the ticker fires
- make sure all loading goroutines are done before returning from loadEntities, loadCachedEntitiesOfLocalAliases
…a test completes: * add Core.ShutdownWait that doesn't return until shutdown is done * create the usedCodes cache on seal and nil it out on pre-seal so that the finalizer kills the janitor goroutine * stop seal health checks on seal rather than wait for them to discover the active context is done * make sure all lease-loading goroutines are done before returning from restore * make uniquePoliciesGc discover closed quitCh immediately instead of only when the ticker fires * make sure all loading goroutines are done before returning from loadEntities, loadCachedEntitiesOfLocalAliases
raskchanky
approved these changes
Feb 22, 2022
sgmiller
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.