Check that all required fields in Transit API are present. #14074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendpclark
approved these changes
Feb 16, 2022
divyapola5
approved these changes
Feb 16, 2022
| @@ -79,6 +79,20 @@ func TestTransit_Trim(t *testing.T) { | |||
| } | |||
| doErrReq(t, req) | |||
|
|
|||
| // Set min_encryption_version to 4 | |||
There was a problem hiding this comment.
Fixed, thanks for the review!
sgmiller
approved these changes
Feb 18, 2022
victorr
force-pushed
the
victorr/fix-transit-required-fields
branch
from
4b789fe to
2ba24e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that an error is returned if any required field is nil or missing.
This fixes an issue that results in the empty string being encrypted when the plaintext is nil.
See VAULT-2837 for details.