identity/oidc: use inherited group membership for client assignments #14013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
requested review from
calvn,
fairclothjm,
robmonte and
vinay-gopalan
fairclothjm
approved these changes
Feb 11, 2022
calvn
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR uses inherited group membership when evaluating client assignments during an OIDC flow.
Given the following group membership tree:
If Entity A authenticates through a client with an assignment that has Group A in its group_ids, the assignment membership check will be satisfied by group inheritance.
Fixes #14005
Testing
I added a test to this PR which sets up a similar scenario to the one explained above.