identity/oidc: adds tests for validation of loopback IP redirect URIs #13939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
requested review from
calvn,
fairclothjm,
robmonte and
vinay-gopalan
|
@paladin-devops - Here is the PR with the test cases. Let me know if you'd like me to add anything else here. |
|
@austingebauer looks great to me, thanks!! |
fairclothjm
reviewed
Feb 7, 2022
Co-authored-by: John-Michael Faircloth <[email protected]>
fairclothjm
approved these changes
Feb 7, 2022
fairclothjm
added a commit
that referenced
this pull request
Feb 12, 2022
…#13939) * identity/oidc: adds tests for validation of loopback IP redirect URIs * Update vault/identity_store_oidc_provider_test.go Co-authored-by: John-Michael Faircloth <[email protected]> Co-authored-by: John-Michael Faircloth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test cases for the loopback IP redirect URI validation behavior fixed in #13871.
Additionally, this moves a function into a new file that was introduced in the PR.