Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add LDAP auth method #13841

Merged
merged 4 commits into from
Feb 4, 2022
Merged

[API] Add LDAP auth method #13841

merged 4 commits into from
Feb 4, 2022

Conversation

RickyGrassmuck
Copy link
Contributor

This commit adds LDAP to the available Vault API auth methods.

Recreated to replace #13465

@RickyGrassmuck
[api] Add LDAP auth method
2fbe357 
This commit adds LDAP to the available Vault API auth methods.
@vercel vercel bot temporarily deployed to Preview – vault-storybook January 29, 2022 15:36 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook January 29, 2022 15:38 Inactive
@RickyGrassmuck RickyGrassmuck mentioned this pull request Jan 29, 2022
Closed
@digivava digivava self-assigned this Jan 31, 2022
@digivava digivava added devex Developer Experience auth/ldap labels Jan 31, 2022
digivava
digivava requested changes Feb 4, 2022
View reviewed changes
Copy link
Collaborator

@digivava digivava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution to this! I've just mentioned one thing you might want to add and then otherwise it seems good to go.

api/auth/ldap/ldap.go Outdated Show resolved Hide resolved
api/auth/ldap/ldap.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 4, 2022 13:55 Inactive
digivava
digivava reviewed Feb 4, 2022
View reviewed changes
api/auth/ldap/ldap.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 4, 2022 16:47 Inactive
digivava
digivava approved these changes Feb 4, 2022
View reviewed changes
Copy link
Collaborator

@digivava digivava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks again!

@digivava digivava merged commit 6dfce8f into hashicorp:main Feb 4, 2022
@RickyGrassmuck RickyGrassmuck deleted the api-auth-ldap branch February 4, 2022 22:19
fairclothjm pushed a commit that referenced this pull request Feb 12, 2022
@RickyGrassmuck @fairclothjm
[API] Add LDAP auth method (#13841)
80f0e72 
* [api] Add LDAP auth method

This commit adds LDAP to the available Vault API auth methods.

* Add changelog entry for PR 13841

* Obtain password for LDAPAuth from File/EnvVar

* Fix name of package in error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digivava digivava digivava approved these changes

Assignees

@digivava digivava

Labels
auth/ldap devex Developer Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RickyGrassmuck @digivava