Time-based transit key autorotation #13691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schultz-is
changed the title
sgmiller
reviewed
Jan 18, 2022
sgmiller
approved these changes
Jan 18, 2022
schultz-is
force-pushed
the
schultz/VAULT-4329
branch
from
281aae0 to
71b5256
Compare
added 11 commits
January 19, 2022 14:43
…ig update endpoints.
…ion happens simultaneously.
schultz-is
force-pushed
the
schultz/VAULT-4329
branch
from
c45c835 to
edf7db2
Compare
sgmiller
approved these changes
Jan 20, 2022
|
Thanks y’all! |
| p.Lock(true) | ||
| } | ||
| err = p.Rotate(ctx, req.Storage, b.GetRandomReader()) | ||
| p.Unlock() |
There was a problem hiding this comment.
Would this panic if caching is disabled? Unlocking a not locked mutex, i believe, panics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces automatic, time-based key rotation to the transit secrets engine. A new field is added to the
keysutil.Policythat keeps track of an interval for key rotation. The value can be specified at key creation time or via a key config update. The value has a minimum of 1 hour and keys are checked for rotation about once an hour.Testing
There are three unit test suites included with this functionality:
TestTransit_CreateKeyWithAutorotationinbuiltin/logical/transit/path_keys_test.gowhich tests the creation of a key with the newauto_rotate_intervalrequest field.TestTransit_UpdateKeyConfigWithAutorotationinbuiltin/logical/transit/path_config_test.gowhich tests the update of an existing key with the newauto_rotate_intervalrequest field.TestTransit_AutoRotateKeysinbuiltin/logical/transit/backend_test.gowhich tests the actual automatic rotation of keys.