Make auth/token/revoke-accessor idempotent #13661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auth/token/revoke will not error out if the token does not exists, it always tries to revoke the token and return success to the client whether or not the token exists. This makes the behavior of auth/token/revoke-accessor coherent with this and remove the need to check whether the token still exists.
|
Hi @remilapeyre! Thanks a lot for this contribution - please don't forget to include a changelog entry. :) |
ncabatoff
reviewed
Jan 17, 2022
Also removes the dubious warning when listing the tokens.
|
Hi @ncabatoff, thanks for the review! Everything should be fine now. |
ncabatoff
approved these changes
Jan 18, 2022
|
Thanks @remilapeyre ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auth/token/revoke will not error out if the token does not exists, it
always tries to revoke the token and return success to the client whether
or not the token exists. This makes the behavior of
auth/token/revoke-accessor coherent with this and remove the need to
check whether the token still exists.
The error had been added by #2391
which added a lot of error reporting across the code so this might just
have been overlooked.
Closes #9636