Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating response for partial month client count #13634

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Conversation

akshya96
Copy link
Contributor

No description provided.

@akshya96 akshya96 requested review from taoism4504 and a team January 11, 2022 23:59
@akshya96 akshya96 changed the title updating custom response for partial month count updating response for partial month client count Jan 12, 2022
Copy link
Contributor

@pmmukh pmmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one note, lgtm!

website/content/api-docs/system/internal-counters.mdx Outdated Show resolved Hide resolved
@taoism4504
Copy link
Contributor

Hi, with the rollout of version docs, we will no longer use docs-cherrypick as the label. Please use the new backport label. More details can be found here: https://docs.google.com/document/d/1MGQDNSdxDb2LsV82eVScz2W1ISfxLchldSIJCvgnutQ/edit#heading=h.n4gqf61g5wah

@@ -195,7 +195,8 @@ $ curl \

## Partial Month Client Count

This endpoint returns the number of clients for the current month, as the sum of active entities and non-entity tokens.
This endpoint returns the number of clients per namespace for the current month, as the sum of clients calculated from the use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to say: as the sum of clients are calculated from the use of active entities and non-entity tokens?

Copy link
Contributor Author

@akshya96 akshya96 Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Just wanted to mean something like this but for the current month

Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question for clarity.

Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG from the docs side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants