UI/Fixes secrets list breadcrumb #13604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add milestone label once backporting is confirmed! |
Monkeychip
reviewed
Jan 8, 2022
| @@ -1,7 +1,7 @@ | |||
| {{#with (options-for-backend @model.engineType) as |options|}} | |||
| <PageHeader as |p|> | |||
| <p.top> | |||
| <KeyValueHeader @baseKey={{this.baseKey}} @path="vault.cluster.secrets.backend.list" @root={{@backendCrumb}}> | |||
| <KeyValueHeader @baseKey={{@baseKey}} @path="vault.cluster.secrets.backend.list" @root={{@backendCrumb}}> | |||
There was a problem hiding this comment.
Ah, probably a backport to 1.9 because I believe in 1.9 I glimmerized this component and this would be a glimmer issue. Nice catch!
There was a problem hiding this comment.
@Monkeychip - from what I could tell this behavior has been happening since before 1.7? But I'll reconfirm next week
Monkeychip
approved these changes
Jan 8, 2022
This was referenced Jan 10, 2022
heppu
pushed a commit
to heppu/vault
that referenced
this pull request
Jan 13, 2022
* fixes basekey param * adds changelog
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breadcrumbs weren't updating as file tree was navigated. Fixes #13581
Bug
With fix