-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/Fixes secrets list breadcrumb #13604
Conversation
Will add milestone label once backporting is confirmed! |
@@ -1,7 +1,7 @@ | |||
{{#with (options-for-backend @model.engineType) as |options|}} | |||
<PageHeader as |p|> | |||
<p.top> | |||
<KeyValueHeader @baseKey={{this.baseKey}} @path="vault.cluster.secrets.backend.list" @root={{@backendCrumb}}> | |||
<KeyValueHeader @baseKey={{@baseKey}} @path="vault.cluster.secrets.backend.list" @root={{@backendCrumb}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, probably a backport to 1.9 because I believe in 1.9 I glimmerized this component and this would be a glimmer issue. Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Monkeychip - from what I could tell this behavior has been happening since before 1.7? But I'll reconfirm next week
* fixes basekey param * adds changelog
Breadcrumbs weren't updating as file tree was navigated. Fixes #13581
Bug
With fix