Search Select Input Fix #13590
Merged
Search Select Input Fix #13590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked at adding test coverage but there are already 16 tests for this component, some of which cover the search and create functionality ported from ember-power-select-with-create which are passing for me after the last commit. |
Monkeychip
reviewed
Jan 6, 2022
| * power-select component. If doing this, `models` should not also be passed as that will overwrite the | ||
| * passed value. | ||
| * @param search {Func} - *Advanced usage* - Customizes how the power-select component searches for matches - | ||
| * @param {function} search - *Advanced usage* - Customizes how the power-select component searches for matches - |
There was a problem hiding this comment.
thank you for cleaning up the documentation!
Monkeychip
reviewed
Jan 6, 2022
| @@ -22,17 +22,14 @@ | |||
| {{/if}} | |||
| {{! template-lint-configure simple-unless "warn" }} | |||
| {{#unless (gte this.selectedOptions.length this.selectLimit)}} | |||
| <PowerSelectWithCreate | |||
| <PowerSelect | |||
There was a problem hiding this comment.
much cleaner, I like it!
Monkeychip
approved these changes
Jan 6, 2022
heppu
pushed a commit
to heppu/vault
that referenced
this pull request
Jan 13, 2022
* removes ember-power-select-with-create dep and updates search-select component * adds changelog * fixes matching when filtering options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in the PowerSelect component where triggering the search input with the mousedown event will cause the input/content to immediately close, forcing the user to hold the mouse button down to interact. Changing to
@eventType="click"fixes the issue but unfortunately the PowerSelectWithCreate component does not proxy that value to PowerSelect.This PR addresses the issue by removing the ember-power-select-with-create and incorporating the necessary functionality into the SearchSelect component which now uses PowerSelect directly.