Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.9: recognize ed25519 key type and return PKCS8 format (#13257) #13276

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Backport 1.9: recognize ed25519 key type and return PKCS8 format (#13257) #13276

merged 2 commits into from
Nov 24, 2021

Conversation

stevendpclark
Copy link
Contributor

@stevendpclark stevendpclark commented Nov 24, 2021 •
edited
Loading

Backport of #13257 to address #13256

  • return pkcs8 format for ed25519 curve

convertRespToPKCS8 does not recognize the ed25519 key. Changes
to recognize ed25519 key and return its PKCS8 format

@navaneethrameshan @stevendpclark
recognize ed25519 key type and return PKCS8 format (#13257)
d776122 
* return pkcs8 format for ed25519 curve

convertRespToPKCS8 does not recognize the ed25519 key. Changes
to recognize ed25519 key and return its PKCS8 format
victorr
victorr approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vercel vercel bot temporarily deployed to Preview – vault November 24, 2021 21:58 Inactive
@stevendpclark stevendpclark merged commit 7946efe into release/1.9.x Nov 24, 2021
@stevendpclark stevendpclark deleted the backport-pr-13257-1.9 branch November 24, 2021 22:20
@stevendpclark stevendpclark mentioned this pull request Nov 24, 2021
Closed
@thiskevinwang thiskevinwang mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorr victorr victorr approved these changes

@schultz-is schultz-is Awaiting requested review from schultz-is

@divyapola5 divyapola5 Awaiting requested review from divyapola5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevendpclark @victorr @navaneethrameshan