Backport 1.9.x: Fixing ResponseWriter to assert to http.Flusher in /sys/monitor endpoint (#13200) #13260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Unify NewHTTPResponseWriter ant NewStatusHeaderResponseWriter to fix ResponseWriter issues * adding changelog * removing unnecessary function from the WrappingResponseWriter interface * changing logical requests responseWriter type * reverting change to HTTPResponseWriter
hghaf099
changed the title
hghaf099
commented
Nov 23, 2021
ncabatoff
reviewed
Nov 23, 2021
hghaf099
commented
Nov 24, 2021
ncabatoff
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of interfaces that implement
http.ResponseWriter. For that, wrappinghttp.ResponseWriterneeds a lot of care.StatusHeaderResponseWriteris instantiated in the http layer which wraps http.ResponseWriter. Then,HTTPResponseWriterwraps the already wrapped ResponseWriter. This causes issues as for example in thesys/monitor, thehttp.Flushercannot be asserted and calling the endpoint returns stream not supported