Add pagination to namespace list view #13195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav28
force-pushed
the
ui/namespace-pagination
branch
from
38e1a7b to
9953626
Compare
hashishaw
reviewed
Nov 23, 2021
hashishaw
reviewed
Nov 29, 2021
| import authPage from 'vault/tests/pages/auth'; | ||
| import logout from 'vault/tests/pages/logout'; | ||
|
|
||
| module('Acceptance | /access/namespaces', function(hooks) { |
There was a problem hiding this comment.
Need to add Enterprise to this module name, since namespaces are enterprise only
There was a problem hiding this comment.
You saved my day...Thanks!! 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added client side pagination for namespaces list view. Default is 15 per page.
Todo: Unit testing
Before (2000 namespaces):
https://user-images.githubusercontent.com/2932708/143089534-4b3785f2-35b0-43bf-a8ff-b371d0967f82.mov
After:
https://user-images.githubusercontent.com/2932708/143089596-a17f1684-3ba3-49aa-85df-b4f4a2990f35.mov