PGP key list input fix #13038
Merged
PGP key list input fix #13038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
reviewed
Nov 4, 2021
| @@ -128,4 +128,26 @@ module('Integration | Component | pgp list', function(hooks) { | |||
| 'lengthening the list with an array with one base64 converted files' | |||
| ); | |||
| }); | |||
|
|
|||
| test('it should render correct amount of file components on listLength change', async function(assert) { | |||
There was a problem hiding this comment.
Thanks for adding test coverage!
Monkeychip
approved these changes
Nov 4, 2021
This was referenced Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported #12056
This fix addresses an issue where the number of PGP Key inputs was not matching the key shares number in the initialization form on change.