UI/ Add PostgreSQL DB #12945
Merged
UI/ Add PostgreSQL DB #12945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
commented
Oct 27, 2021
| @@ -1,4 +1,24 @@ | |||
| export const AVAILABLE_PLUGIN_TYPES = [ | |||
| { | |||
There was a problem hiding this comment.
Moved elasticsearch to the top because alphabetized plugin list
hashishaw
approved these changes
Oct 28, 2021
hashishaw
approved these changes
Oct 28, 2021
hellobontempo
commented
Oct 29, 2021
| .dom('[data-test-toggle-input="show-username_template"]') | ||
| .exists(`Username template toggle exists for ${name}`); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Tests fail when Oracle isn't the last database - since actually connecting Oracle is skipped after checking that the fields exist, the test doesn't redirect to the connection list page and start the connecting a database process over. (And the test checks for an empty state when no DB is selected)
hellobontempo
added a commit
that referenced
this pull request
Oct 29, 2021
* alphabetize DB plugin types * adds changelog * add postgres to database plugins * add statement fields * adds tests for postgres db * add delete confirm modal to db connection * fixes text for confirmation modal - transform * editing tests for delete modal * fixes tests, oracle must be last DB tested * adds test for modal and updates old modal tests
hellobontempo
added a commit
that referenced
this pull request
Oct 30, 2021
* alphabetize DB plugin types * adds changelog * add postgres to database plugins * add statement fields * adds tests for postgres db * add delete confirm modal to db connection * fixes text for confirmation modal - transform * editing tests for delete modal * fixes tests, oracle must be last DB tested * adds test for modal and updates old modal tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI support for PostgreSQL DB and adds confirmation modal when deleting a database connection:
