Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend kv metadata to get, put, and patch #12907

Merged
merged 7 commits into from
Oct 26, 2021
Merged

Extend kv metadata to get, put, and patch #12907

merged 7 commits into from
Oct 26, 2021

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented Oct 22, 2021 •
edited
Loading

This PR provides test changes to verify CLI output for the extension of KVv2's key metadata field custom_metadata to the CreateOperation, ReadOperation, and PatchOperation responses for the /<mount>/data/:path endpoint. The affected CLI commands are vault kv get secret/foo, vault kv put secret/foo, vault kv patch secret/foo.

Related Issues/Pull Requests

@ccapurso ccapurso changed the title Extend kv metadata to get and put Extend kv metadata to get, put, and patch Oct 25, 2021
@ccapurso ccapurso mentioned this pull request Oct 25, 2021
Merged
@vercel vercel bot temporarily deployed to Preview – vault October 25, 2021 20:04 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 25, 2021 20:04 Inactive
@ccapurso ccapurso added this to the 1.9 milestone Oct 25, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 26, 2021 13:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 26, 2021 13:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 26, 2021 13:30 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 26, 2021 13:30 Inactive
@ccapurso ccapurso marked this pull request as ready for review October 26, 2021 16:43
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 26, 2021 17:23 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 26, 2021 17:23 Inactive
hghaf099
hghaf099 approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@hghaf099 hghaf099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

command/kv_test.go Show resolved Hide resolved
@ccapurso ccapurso merged commit 237ea55 into main Oct 26, 2021
@ccapurso ccapurso deleted the extend-kv-metadata-to-get-and-put branch October 26, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hghaf099 hghaf099 hghaf099 approved these changes

Assignees
No one assigned
Labels
enhancement secret/kv
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
2 participants
@ccapurso @hghaf099