[VAULT-3008] Update RabbitMQ dependency and fix regression in UserInfo.Tags in v3.9 #12877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the go.mod to use
github.com/michaelklishin/rabbit-hole/v2which is the latest version of the package. This was done to resolve a RabbitMQ regression in v3.9 with UserInfo.Tags; they now return a string array instead of a string.With this update, we can now use the image
3-managementinbackend_test.goand do not need to pin the docker image versions as done previously in this PR. The only change in Vault logic is passingrole.Tagsas a string array when trying to set theUserInfo.tagsfield inpath_role_create.go.