agent/cache: Store leases in-order in persistent cache so that restore respects dependencies #12843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
reviewed
Oct 18, 2021
calvn
reviewed
Oct 18, 2021
calvn
approved these changes
Oct 25, 2021
benashz
reviewed
Oct 26, 2021
| }) | ||
|
|
||
| if err := tx.DeleteBucket([]byte(v1BucketType)); err != nil { | ||
| return fmt.Errorf("failed to clean up %s bucket during v1 to v2 schema migration: %w", v1BucketType, err) |
There was a problem hiding this comment.
Does this mean we need to do the migration once more? Could we end up in a state where a migration will never succeed? If so, perhaps it would make sense to scrap the db and start fresh.
There was a problem hiding this comment.
If the migration fails, something super weird has happened because migrations should be very rare (we only explicitly support persistent stores in k8s today) and failures should also be very rare because the schema creation/migration code is very lenient. So I'd prefer that an operator gets a chance to clean up/debug before we wipe everything automatically.
…s' of github.com:hashicorp/vault into agent-persistent-cache-restore-dependencies-ordered-keys
tomhjp
deleted the
agent-persistent-cache-restore-dependencies-ordered-keys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #12765. Here we depend on BoltDB storing, and iterating on keys in its bucket, in byte slice order, and use an auto-incrementing index to store each lease in the same order it was created. When we then restore from the persistent storage, it should automatically restore in dependency order.