Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Oracle db connection #12752

Merged
merged 9 commits into from
Oct 11, 2021
Merged

Added support for Oracle db connection #12752

merged 9 commits into from
Oct 11, 2021

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented Oct 6, 2021

Screen Shot 2021-10-06 at 11 03 28 AM

@arnav28 arnav28 added the ui label Oct 6, 2021
@vercel vercel bot temporarily deployed to Preview – vault October 6, 2021 18:09 Inactive
@arnav28 arnav28 added this to the 1.9 milestone Oct 6, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 6, 2021 18:18 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 6, 2021 19:15 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 6, 2021 23:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 7, 2021 16:19 Inactive
Monkeychip
Monkeychip requested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for Claire's PR to merge before final approval as there are some changes that need to happen.

changelog/12752.txt Show resolved Hide resolved
ui/app/components/database-role-setting-form.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 7, 2021 21:33 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 7, 2021 21:33 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 7, 2021 21:42 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 7, 2021 21:42 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 7, 2021 21:58 Inactive
hashishaw
hashishaw approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @hellobontempo will need to make sure to pull in the role fields into the util once you merge this

@vercel vercel bot temporarily deployed to Preview – vault October 8, 2021 17:41 Inactive
hashishaw
hashishaw approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arnav28 arnav28 merged commit d919e32 into main Oct 11, 2021
@arnav28 arnav28 deleted the ui/oracle-db branch October 11, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo left review comments

@hashishaw hashishaw hashishaw approved these changes

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@arnav28 @Monkeychip @hellobontempo @hashishaw