-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unpublished:true for sys/internal/* endpoints #12713
Removed unpublished:true for sys/internal/* endpoints #12713
Conversation
@saltperfect Thanks for submitting this PR. Would you please add the changelog text file related to this change as well? Also, if you would please add some documentation on those unpublished endpoints, that would be great. We don't need thorough docs on those, just something to acknowledge their existence would suffice for now. With those changes, we can go ahead and merge this PR. |
changelog/_12713.txt
Outdated
@@ -0,0 +1,3 @@ | |||
```release-note:bug | |||
COMPONENT: removed unpublished true from logical_system path, making openapi spec consistent with documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name of the file contains an "_", please remove it.
…re not mentioned in docs.
I have edited 5 entries in logical_paths_system.go
For now I have put in a really dumb entry for Summary. Let me know if this works. |
Please remove the summary and add two mdx files for |
I have added the two mdx files. I have kept it quite similar. Please let me know if any changes required. |
@saltperfect Thank you very much for adding the docs. Seems like the deployment check failed since the added new endpoints mdx files, are not reflected in the api docs nav data file located here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #12282
Removed Unpublished true to make open api spec consistent with documentation.
Namely
internal/ui/namespaces
,internal/ui/resultant-acl
,internal/counters/requests
,internal/counters/tokens
,internal/counters/entities
Useful Links