-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing read unlock calls in transit backend code #12652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyapola5
requested review from
victorr,
cipherboy,
sgmiller and
rculpepper
September 27, 2021 21:29
victorr
approved these changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, but please verify the changelog entry with someone (maybe Scott?)
sgmiller
requested changes
Sep 28, 2021
sgmiller
approved these changes
Sep 28, 2021
divyapola5
added a commit
that referenced
this pull request
Sep 28, 2021
* Add missing read unlock calls in transit backend code * Correct formatting in changelog entry
sgmiller
pushed a commit
that referenced
this pull request
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup for #12418 and in summary includes the following changes:
1 - Add missing read unlock calls for cacheSizeChanged variable
2 - Invoke initCache in pathCacheConfigRead routine if needed