Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/bar chart updates #12622

Merged
merged 15 commits into from
Sep 27, 2021
Merged

UI/bar chart updates #12622

merged 15 commits into from
Sep 27, 2021

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Sep 23, 2021

To Dos:

  • Chart re-renders when new dates are queries
  • Awry tooltip
  • Double rendering of total values
  • Double rendering of y-axis labels

Copy link
Contributor

@arnav28 arnav28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of dataset getter on line 67?

@hellobontempo hellobontempo added this to the 1.9 milestone Sep 24, 2021
@hellobontempo
Copy link
Contributor Author

hellobontempo commented Sep 24, 2021

We can get rid of dataset getter on line 67?

Yes! Once we update the template - thank you for catching

@vercel vercel bot temporarily deployed to Preview – vault September 27, 2021 15:40 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 27, 2021 15:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants