-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to support VAULT_HTTP_PROXY variable #12582
Patch to support VAULT_HTTP_PROXY variable #12582
Conversation
Hello, and welcome to the HashiCorp Vault community! Please note that we are moving to a process where PRs need to be associated with an issue, either an existing one or a new issue, so that the community and the engineers can discuss implementation details, strategy, and where the request fits into an existing roadmap. Additionally, all PRs do need to have the CLA signed. Please feel free to create or link an existing issue to this PR. Thanks! |
f6a553a
to
b39bfbb
Compare
The CLA signing has now been recognised properly and an issue to cover this has been created here: #12613 |
Changes look good, could you also update https://github.com/hashicorp/vault/blob/main/website/content/docs/commands/index.mdx#environment-variables please? |
Oh, and we'll also need a changelog entry, as described in https://github.com/hashicorp/vault/blob/main/CONTRIBUTING.md#changelog-entries |
Looks good, thanks! You'll need to merge in the latest changes from |
c1ec453
to
7c10fcd
Compare
What has been changed
This patch creates VAULT_HTTP_PROXY which can be used to override the default behavior of the Vault API Client.
HTTPS_PROXY
as before so the changes should likely not affect any existing users.Why is this useful
If the Vault Client has been embedded in software (e.g. terraform provider, consul-template or other) that might need to use different proxies to talk to vault vs other upstream services such as AWS, Azure, GCP (as described in hashicorp/terraform-provider-vault#1150), this allows the vault behavior to be specifically controlled.