-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/ PKI UI Redesign #12541
UI/ PKI UI Redesign #12541
Conversation
Any way, thanks for your work~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work! A couple small updates requested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@hellobontempo will there need to be documentation updates for this change? |
@mladlow - Thanks for checking! Nope - I don't think so. The only relevant docs I see are Build Your Own Certificate Authority (CA) and I don't seen any screenshots that display the certificate data. This PR is just visual and adds some of the cert metadata to the certificate view page. |
Utilizes node-forge to parse the PKI certificate's metadata and display
issueDate
,expiryDate
andcommonName
:Previous behavior:
Current behavior: