creds/aws: Add support for DSA signature verification for EC2 #12340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
requested review from
kalafut,
sgmiller,
calvn,
briankassouf and
a team
sgmiller
approved these changes
Aug 18, 2021
calvn
reviewed
Aug 18, 2021
calvn
reviewed
Aug 18, 2021
calvn
approved these changes
Aug 18, 2021
Co-authored-by: Calvin Leung Huang <[email protected]>
Co-authored-by: Calvin Leung Huang <[email protected]>
jasonodonnell
added a commit
that referenced
this pull request
Aug 19, 2021
* creds/aws: import pkcs7 verification package * Add DSA support * changelog * Add DSA to correct verify function * Remove unneeded tests * Fix backend test * Update builtin/credential/aws/pkcs7/README.md Co-authored-by: Calvin Leung Huang <[email protected]> * Update builtin/credential/aws/path_login.go Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]>
jasonodonnell
added a commit
that referenced
this pull request
Aug 20, 2021
#12361) * creds/aws: import pkcs7 verification package * Add DSA support * changelog * Add DSA to correct verify function * Remove unneeded tests * Fix backend test * Update builtin/credential/aws/pkcs7/README.md Co-authored-by: Calvin Leung Huang <[email protected]> * Update builtin/credential/aws/path_login.go Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]>
ncabatoff
pushed a commit
that referenced
this pull request
Dec 14, 2021
* creds/aws: import pkcs7 verification package * Add DSA support * changelog * Add DSA to correct verify function * Remove unneeded tests * Fix backend test * Update builtin/credential/aws/pkcs7/README.md Co-authored-by: Calvin Leung Huang <[email protected]> * Update builtin/credential/aws/path_login.go Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]>
jcharum
pushed a commit
to grailbio/base
that referenced
this pull request
Jun 2, 2022
Summary: AWS Identity Documents are signed with DSA-with-SHA1 signatures, and DSA is removed from x509/crypto as of Go 1.16. This follows an approach done by hashicorp/vault#12340, by forking in https://github.com/mozilla-services/pkcs7 and applying the DSA fix mozilla-services/pkcs7#50. Test Plan: - Tested Bazel build and go build from within the folder Reviewers: aeiser, dborcherding, sdunn, anguyen, gvitta, bbentson Reviewed By: dborcherding, sdunn Subscribers: jcharumilind, dnicolaou, pboyapalli, smahadevan Differential Revision: https://phabricator.grailbio.com/D66326 fbshipit-source-id: cafa39b
swenson
pushed a commit
that referenced
this pull request
Dec 22, 2022
This was not copied over when the this code was copied in #12340. Also adds a stub for the `.copywrite.hcl` file (for when Vault is onboarded to Copywrite) and adds the `pkcs7` and `ui/node_modules` to the ignore pattern.
swenson
pushed a commit
that referenced
this pull request
Dec 22, 2022
This was not copied over when the this code was copied in #12340. Also adds a stub for the `.copywrite.hcl` file (for when Vault is onboarded to Copywrite) and adds the `pkcs7` and `ui/node_modules` to the ignore pattern.
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
This was not copied over when the this code was copied in #12340. Also adds a stub for the `.copywrite.hcl` file (for when Vault is onboarded to Copywrite) and adds the `pkcs7` and `ui/node_modules` to the ignore pattern.
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
This was not copied over when the this code was copied in #12340. Also adds a stub for the `.copywrite.hcl` file (for when Vault is onboarded to Copywrite) and adds the `pkcs7` and `ui/node_modules` to the ignore pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSA support was dropped in Go 1.16 which is used by the EC2 auth method for verifying signatures. Since this was dropped from a core library and EC2 needs DSA support until we can switch to RSA, I needed to bring in the external package we were using for verification and alter the code to add support. RSA adoption is a high priority task so we can formally deprecate the DSA support in Vault.