-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update influxdb client #12262
Update influxdb client #12262
Conversation
Note that this PR updates the current influxdb1 client to the correct library at https://github.com/influxdata/influxdb1-client. Issue #12230 requests influxdb2 support, which would be https://github.com/influxdata/influxdb-client-go instead. |
* Influxdb v1 client has been split into separate module from main influxdb code base. This changes uses the correct client, which also allows us to get updates and avoids confusing some vuln scanners that flagged previous version incorrectly with vulnerabilities. Fixes hashicorp#6088.
62f9008
to
6629a68
Compare
Updated the PR with missing changelog entry. |
We are seeing our image scanner triggering on this. Any chance to get this PR rebased, reviewed and merged? |
I've merged main. @pmmukh would you happen to know if this PR could be reviewed and considered for merging to get rid of security alerts? Should be relatively trivial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related tests are passing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Only a small update to the changelog stub.
Co-authored-by: Ben Ash <[email protected]>
After applying the changelog update |
Seems to be unrelated to this change. We'll look into thanks! |
Influxdb v1 client has been split into separate module from main influxdb code base. This change uses the correct client, which also allows us to get updates and avoids confusing some vuln scanners that flagged previous version incorrectly with vulnerabilities that applied only to the main code base.
Fixes #6088.